Skip to content

[SPARK-36159][BUILD] Replace 'python' to 'python3' in dev/test-dependencies.sh#33368

Closed
HyukjinKwon wants to merge 1 commit into
apache:masterfrom
HyukjinKwon:change-python-3
Closed

[SPARK-36159][BUILD] Replace 'python' to 'python3' in dev/test-dependencies.sh#33368
HyukjinKwon wants to merge 1 commit into
apache:masterfrom
HyukjinKwon:change-python-3

Conversation

@HyukjinKwon

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

This PR is a followup of #26330. There is the last place to fix in dev/test-dependencies.sh

Why are the changes needed?

To stick to Python 3 instead of using Python 2 mistakenly.

Does this PR introduce any user-facing change?

No, dev-only.

How was this patch tested?

Manually tested.

@SparkQA

SparkQA commented Jul 15, 2021

Copy link
Copy Markdown

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45591/

@SparkQA

SparkQA commented Jul 15, 2021

Copy link
Copy Markdown

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45591/

@SparkQA

SparkQA commented Jul 15, 2021

Copy link
Copy Markdown

Test build #141077 has finished for PR 33368 at commit 81ac978.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun

Copy link
Copy Markdown
Member

Retest this please

@dongjoon-hyun dongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.
The Python UT failures are irrelevant because this changes dev/test-dependenciess.sh only. Merged to master/3.2/3.1/3.0.

dongjoon-hyun pushed a commit that referenced this pull request Jul 15, 2021
…encies.sh

### What changes were proposed in this pull request?

This PR is a followup of #26330. There is the last place to fix in `dev/test-dependencies.sh`

### Why are the changes needed?

To stick to Python 3 instead of using Python 2 mistakenly.

### Does this PR introduce _any_ user-facing change?

No, dev-only.

### How was this patch tested?

Manually tested.

Closes #33368 from HyukjinKwon/change-python-3.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 6bd385f)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun pushed a commit that referenced this pull request Jul 15, 2021
…encies.sh

### What changes were proposed in this pull request?

This PR is a followup of #26330. There is the last place to fix in `dev/test-dependencies.sh`

### Why are the changes needed?

To stick to Python 3 instead of using Python 2 mistakenly.

### Does this PR introduce _any_ user-facing change?

No, dev-only.

### How was this patch tested?

Manually tested.

Closes #33368 from HyukjinKwon/change-python-3.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 6bd385f)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun pushed a commit that referenced this pull request Jul 15, 2021
…encies.sh

### What changes were proposed in this pull request?

This PR is a followup of #26330. There is the last place to fix in `dev/test-dependencies.sh`

### Why are the changes needed?

To stick to Python 3 instead of using Python 2 mistakenly.

### Does this PR introduce _any_ user-facing change?

No, dev-only.

### How was this patch tested?

Manually tested.

Closes #33368 from HyukjinKwon/change-python-3.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 6bd385f)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun

Copy link
Copy Markdown
Member

Thank you, @HyukjinKwon .

flyrain pushed a commit to flyrain/spark that referenced this pull request Sep 21, 2021
…encies.sh

### What changes were proposed in this pull request?

This PR is a followup of apache#26330. There is the last place to fix in `dev/test-dependencies.sh`

### Why are the changes needed?

To stick to Python 3 instead of using Python 2 mistakenly.

### Does this PR introduce _any_ user-facing change?

No, dev-only.

### How was this patch tested?

Manually tested.

Closes apache#33368 from HyukjinKwon/change-python-3.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 6bd385f)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@HyukjinKwon HyukjinKwon deleted the change-python-3 branch January 4, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants